fix(reportcard): fix issues identified in go report card

target · Sep 5, 2018 · 0b1960e · 0b1960e
1 parent f251d0c
commit 0b1960e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/core/configure.go b/core/configure.go
@@ -111,7 +111,7 @@ func configureChatApplication(bot *models.Bot) {
 			if err != nil {
 				bot.Log.Errorf("Could not set Slack Events API callback path: %s", err.Error())
 				bot.Log.Warn("Defaulting to use Slack RTM")
-				vToken = ""
+				bot.SlackVerificationToken = ""
 			}
 			bot.SlackEventsCallbackPath = eCallbackPath
 

diff --git a/remote/discord/remote.go b/remote/discord/remote.go
@@ -99,13 +99,11 @@ func handleDiscordMessage(bot *models.Bot, inputMsgs chan<- models.Message) inte
 		message := models.NewMessage()
 		switch m.Type {
 		case discordgo.MessageTypeDefault:
-			timestamp := ""
 			t, err := m.Timestamp.Parse()
 			if err != nil {
 				bot.Log.Errorf("Discord Remote: Failed to parse message timestamp.")
-				timestamp = "0"
 			}
-			timestamp = strconv.FormatInt(t.Unix(), 10)
+			timestamp := strconv.FormatInt(t.Unix(), 10)
 			msgType := models.MsgTypeChannel
 			switch ch.Type {
 			case discordgo.ChannelTypeDM:

diff --git a/version/version.go b/version/version.go
@@ -7,7 +7,9 @@ import (
 )
 
 var (
+	// Version supplies the semantic version
 	Version string
+	// GitHash supplies the git sha hash used
 	GitHash string
 )