Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docker files to use go modules #105

Merged
merged 4 commits into from
Jun 18, 2019

Conversation

sarge
Copy link
Contributor

@sarge sarge commented May 31, 2019

❤ THANKS FOR HELPING OUT :D

Proposed change

Updates docker files.
closes #103

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented May 31, 2019

Pull Request Test Coverage Report for Build 219

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.444%

Totals Coverage Status
Change from base Build 217: 0.0%
Covered Lines: 781
Relevant Lines: 1980

💛 - Coveralls

@sjqnn
Copy link
Collaborator

sjqnn commented Jun 4, 2019

If we're ripping out dep from all of the image flavored Dockerfiles, we may as well remove it from the base Dockerfile as well. https://github.com/target/flottbot/blob/master/docker/Dockerfile#L8

@sarge
Copy link
Contributor Author

sarge commented Jun 7, 2019

@sjqnn Updated that one too:)

Makefile Show resolved Hide resolved
@JordanSussman
Copy link
Collaborator

LGTM besides the one minor Makefile update.

@JordanSussman
Copy link
Collaborator

I just resolved the merge conflicts and addressed the one issue for the Makefile. Anyone else have objections to getting this merged?

Copy link
Contributor

@delta592 delta592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@delta592 delta592 merged commit 800d839 into target:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dockerfile(s) to utilize go modules
5 participants