Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): allow standard and quartz spec #126

Merged
merged 5 commits into from Feb 19, 2020
Merged

feat(scheduler): allow standard and quartz spec #126

merged 5 commits into from Feb 19, 2020

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Feb 14, 2020

❤ THANKS FOR HELPING OUT :D

Proposed change

Updates cron lib to newest version. This will now support both standard and quartz spec syntax for cron scheduling.

closes #20

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@wass3r wass3r self-assigned this Feb 14, 2020
@wass3r wass3r added the enhancement New feature or request label Feb 14, 2020
@coveralls
Copy link

coveralls commented Feb 14, 2020

Pull Request Test Coverage Report for Build 281

  • 0 of 24 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 37.701%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/scheduler/remote.go 0 24 0.0%
Totals Coverage Status
Change from base Build 276: -0.2%
Covered Lines: 820
Relevant Lines: 2175

💛 - Coveralls

Copy link
Collaborator

@JordanSussman JordanSussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

remote/scheduler/remote.go Outdated Show resolved Hide resolved
@wass3r wass3r merged commit d2a9ae3 into master Feb 19, 2020
@wass3r wass3r deleted the scheduler branch February 19, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler spec that utilize "/" will not work
3 participants