Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reverting dockerfiles due to docker bug #137

Merged
merged 3 commits into from Apr 4, 2020
Merged

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Apr 4, 2020

❤ THANKS FOR HELPING OUT :D

Proposed change

Noticed an issue during the docker image build. Apparently there's a bug with multiple successive COPY statements in Docker that we're affected by, see moby/moby/issues/37965 . Instead of applying known workaround, reverting Dockerfiles back to old setup w/ some tweaks.

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

apparently there's a bug with multiple successive COPY statements in Docker, see moby/moby/issues/37965
@github-actions
Copy link

github-actions bot commented Apr 4, 2020

Pull Request Test Coverage Report for Build 6a8613077004fc8ba135479cc1062de9a38c125d-PR-137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.238%

Totals Coverage Status
Change from base Build c6aed2f77966a8e3b86120575a4baaf45ef51370: 0.0%
Covered Lines: 770
Relevant Lines: 1823

💛 - Coveralls

@wass3r wass3r changed the title ci: apply workaround for docker bug ci: reverting dockerfiles due to docker bug Apr 4, 2020
@wass3r wass3r merged commit 807156f into master Apr 4, 2020
@wass3r wass3r deleted the apply-docker-fix branch April 4, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants