Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(slack): improve startup speed #469

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Jun 19, 2023

on slack workspaces with large user counts the startup time can be quite long (witnessed 15m+) due to fetching all users, usergroups, and rooms.

the changes in this PR include:

  • remove fetching users as it's currently not utilized - this was also the bulk of the problem
  • make fetching usergroups and rooms async

i believe the original intent was to fetch once and have a local lookup and only turn to Slack api calls when needed. it might be re-introduced at a later point in a sensible manner.

@wass3r wass3r added enhancement New feature or request slack slack remote specific labels Jun 19, 2023
@wass3r wass3r self-assigned this Jun 19, 2023
@coveralls
Copy link

coveralls commented Jun 19, 2023

Pull Request Test Coverage Report for Build 5308635091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 5157599379: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@wass3rw3rk wass3rw3rk merged commit 81b39ee into main Jun 20, 2023
10 checks passed
@wass3rw3rk wass3rw3rk deleted the enhance/slack/startup branch June 20, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request slack slack remote specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants