Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(viper): add viper to handle multi format config #64

Merged
merged 7 commits into from
Oct 8, 2018

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Oct 8, 2018

closes #15

❤ THANKS FOR HELPING OUT :D

Proposed change

Integrates spf13/viper to be able to handle multiple config formats

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Oct 8, 2018

Pull Request Test Coverage Report for Build 123

  • 3 of 36 (8.33%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 38.078%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/rules.go 0 11 0.0%
cmd/flottbot/main.go 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/flottbot/main.go 4 9.84%
Totals Coverage Status
Change from base Build 111: -0.07%
Covered Lines: 741
Relevant Lines: 1946

💛 - Coveralls

sjqnn
sjqnn previously approved these changes Oct 8, 2018
@JordanSussman JordanSussman merged commit 71d5f56 into master Oct 8, 2018
@JordanSussman JordanSussman deleted the add-viper branch October 8, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize spf13/viper to support multiple config formats
5 participants