You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
In hercules-ci/gitignore.nix#32 we noticed that using readDir (and searching for .gitignore files outside of the project directory) would watch way to many directories recursively. hercules-ci/gitignore.nix#33 should fix that, but we have to confirm.
The text was updated successfully, but these errors were encountered:
straceing this, it looks to me like the readDirs stop at the Git repo boundary in either case, except for special files like $HOME/.gitconfig and $XDG_CONFIG_DIR/git/config.
If there is a $HOME/.gitconfig then lorri will watch its parent directory, $HOME, and that may already lead to watcher issues.
This does not explain why users were seeing / and /nix being watched by lorri. But it does point to a problem that is not solved by hercules-ci/gitignore.nix#32.
On some platforms, if the path is renamed or removed while being watched, behaviour may be unexpected. [...] If less surprising behaviour is wanted one may non-recursively watch the parent directory as well and manage related events.
In hercules-ci/gitignore.nix#32 we noticed that using
readDir
(and searching for.gitignore
files outside of the project directory) would watch way to many directories recursively. hercules-ci/gitignore.nix#33 should fix that, but we have to confirm.The text was updated successfully, but these errors were encountered: