Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better examples, with details about service accounts #42

Merged
merged 2 commits into from Feb 26, 2020
Merged

better examples, with details about service accounts #42

merged 2 commits into from Feb 26, 2020

Conversation

brianberzins
Copy link
Collaborator

Documentation request: #41

  • updated documentation regarding service accounts and required permissions
  • included examples of setting up pod-reaper with both cluster-wide and namespace-specific permissions
  • consolidated examples into an examples folder
  • expanded examples to include setup of all k8s resources (including service accounts/role bindings/namespaces) to make it easier to understand everything at work
  • updated manifest files to be compliant with kubernetes version 1.17

@brianberzins brianberzins mentioned this pull request Feb 10, 2020
Open
@brianberzins
Copy link
Collaborator Author

Looking for feedback on these examples!

@brianberzins
Copy link
Collaborator Author

@JordanSussman or @slushpupie
how do you feel about these compared to previous examples?

@slushpupie
Copy link
Member

Seems like reasonable examples to me.

JordanSussman
JordanSussman approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@JordanSussman JordanSussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianberzins
Copy link
Collaborator Author

@slushpupie
Updated this PR to resolve conflicts

@slushpupie slushpupie merged commit aca14c5 into target:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanSussman JordanSussman JordanSussman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianberzins @slushpupie @JordanSussman