feat: simplify inner-product generator folding #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
prover-speedup
branch
from
d396b1d
to
9d3e9d8
Compare
SWvheerden
approved these changes
Aug 4, 2023
hansieodendaal
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
ACK
Nice improvement. See my prover bench results below (this PR was the 1st run)
[BP+ this PR = red, BP+ main = blue]
- range_proof_creation/Agg 64-bit BP+ create agg factor 1 degree DefaultPedersen
- range_proof_creation/Agg 64-bit BP+ create agg factor 2 degree DefaultPedersen
- range_proof_creation/Agg 64-bit BP+ create agg factor 4 degree DefaultPedersen
- range_proof_creation/Agg 64-bit BP+ create agg factor 8 degree DefaultPedersen
Merged
stringhandler
pushed a commit
that referenced
this pull request
Aug 7, 2023
## [0.3.2](v0.3.1...v0.3.2) (2023-08-07) ## Features * change precomputation `rc` to `arc` ([44](#44)) ([d495fb2](d495fb2)) * minor verifier optimizations ([53](#53)) ([7960214](7960214)) * simplify inner-product generator folding ([52](#52)) ([271892c](271892c)) ## Bug Fixes * promise check in range statement ([48](#48)) ([3e0008e](3e0008e)) * reduce vector capacity ([45](#45)) ([9caa0c9](9caa0c9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the handling of prover inner-product generator folding for efficiency. Currently, this folding process is done using element-by-element scalar-group multiplication followed by group addition. This PR combines these operations into element-by-element multiscalar multiplications. The result is an impressive 35% speedup for single 64-bit range proving.
Also removes unnecessary helper functions.