Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: promise check in range statement #48

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

AaronFeickert
Copy link
Contributor

Range statement initialization requires the number of minimum value promises to match the number of commitments. There's currently a logic error that renders this check incorrect.

This PR fixes the logic. A test will be included in a broader test PR, but the logic change is here for scope.

Copy link
Contributor

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@CjS77 CjS77 merged commit 3e0008e into tari-project:main Jul 21, 2023
5 checks passed
@AaronFeickert AaronFeickert deleted the fix-promise-check branch July 21, 2023 15:18
@SWvheerden SWvheerden mentioned this pull request Aug 7, 2023
stringhandler pushed a commit that referenced this pull request Aug 7, 2023
##
[0.3.2](v0.3.1...v0.3.2)
(2023-08-07)


## Features

* change precomputation `rc` to `arc`
([44](#44))
([d495fb2](d495fb2))
* minor verifier optimizations
([53](#53))
([7960214](7960214))
* simplify inner-product generator folding
([52](#52))
([271892c](271892c))


## Bug Fixes

* promise check in range statement
([48](#48))
([3e0008e](3e0008e))
* reduce vector capacity
([45](#45))
([9caa0c9](9caa0c9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants