feat: minor verifier optimizations #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
approved these changes
Aug 7, 2023
Merged
stringhandler
pushed a commit
that referenced
this pull request
Aug 7, 2023
## [0.3.2](v0.3.1...v0.3.2) (2023-08-07) ## Features * change precomputation `rc` to `arc` ([44](#44)) ([d495fb2](d495fb2)) * minor verifier optimizations ([53](#53)) ([7960214](7960214)) * simplify inner-product generator folding ([52](#52)) ([271892c](271892c)) ## Bug Fixes * promise check in range statement ([48](#48)) ([3e0008e](3e0008e)) * reduce vector capacity ([45](#45)) ([9caa0c9](9caa0c9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few minor optimizations to the verifier.
In the case of verification with no mask extraction, the vector used to store optional mask data is constructed empty with no capacity hint, but has
Nonevalues pushed to it, resulting in unnecessary reallocation. This is now fixed by performing the correct allocation immediately.A few scalar multiplications were being performed repeatedly. These are now computed only once per proof.