feat: move RNGs into RangeProofTranscript
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
TranscriptRng into RangeProofTranscriptRangeProofTranscript
AaronFeickert
force-pushed
the
transcript-rng
branch
from
a5b48dd
to
f6cb907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent work in #109 uses Merlin's
TranscriptRngfunctionality to improve handling of random number generation, and also refactors transcript operations for safer use through aRangeProofTranscriptwrapper.A suggestion by @sdbondi recommends moving the
TranscriptRngintoRangeProofTranscriptso the prover and verifier aren't responsible for it. This PR adds such a change.It also updates
RangeProofTranscriptto hold a mutable reference to the external random number generator. This ensures that the prover and verifier can't accidentally use it instead of theTranscriptRng.