chore: inner-product protocol cleanup #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
ipp-clones
branch
from
d49f076
to
640771d
Compare
AaronFeickert
force-pushed
the
ipp-clones
branch
from
640771d
to
6d7c77b
Compare
CjS77
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Oddly, the benchmarks were not faster with this PR on my Macbook Pro (2018). Though it was difficult to replicate due the CPU throttling issues, it looks like the clones are very fast compared to other operations. Maybe the iters have some overhead vs a contiguous block of memory that a vec has 🤷
Nevertheless, I like this.. it's cleaner and must be more memory efficient
|
Yeah, I wondered about whether the use of iterators incurred any overhead, but didn't find anything definitive about this. The scalar computation duplication overhead should be small compared to group operations, and it seems reasonable that it could fall within the noise threshold of benchmarking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner-product protocol implementation includes many unnecessary clones when computing per-round multiscalar multiplication evaluations. These are unnecessary, since the evaluation function can accept reference iterators. Further, some multiplicative scalar offsets were being computed twice.
This PR cleans up these parts of the protocol for memory and computational efficiency, The evaluations now use only references, eliminating the clones. It's also more clever about scalar offsets to reduce duplicated computations.
Closes #33.