fix: verifier overflow checks #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
overflow-checks
branch
from
00e40c3
to
5465457
Compare
4 tasks
AaronFeickert
force-pushed
the
overflow-checks
branch
from
5465457
to
98ca0c6
Compare
AaronFeickert
force-pushed
the
overflow-checks
branch
from
98ca0c6
to
2fcb866
Compare
AaronFeickert
force-pushed
the
overflow-checks
branch
from
985ef15
to
b7380c6
Compare
SWvheerden
reviewed
Sep 20, 2023
AaronFeickert
force-pushed
the
overflow-checks
branch
from
b7380c6
to
69d2872
Compare
SWvheerden
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for overflows in the range verifier.
Since type exceptions for the lint mentioned in #60 don't seem to work with the Ristretto types, this needs to either be checked manually or by temporarily enabling that lint and ignoring the deluge of Ristretto false positives (operations on those types are not subject to overflow/underflow).
Also does minor cleanup by moving some operations to iterators.
Closes #60.