chore!: clean up ExtensionDegree
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
ExtensionDegreeExtensionDegree
AaronFeickert
force-pushed
the
extension-degree-cleanup
branch
3 times, most recently
from
aad4e64
to
42b38bf
Compare
AaronFeickert
force-pushed
the
extension-degree-cleanup
branch
from
42b38bf
to
bc19980
Compare
stringhandler
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ExtensionDegreediscriminants are represented asisizeby the compiler. The enumeration implementsTryFrom<usize>via a wrapper to a public functionExtensionDegreee::try_from_sizethat is used in the library. This is inelegant, makes deserialization (which acts on bytes) more awkward, and introduces the possibility that a future enumeration update could overflowu8and cause serialization problems.This PR moves the functionality of
ExtensionDegree::try_from_sizeinto aTryFrom<u8>implementation, and implementsTryFrom<usize>as a wrapper. It changes the discriminant representation tou8, which will ensure that any future change toExtensionDegreethat could overflow will be caught by the compiler.BREAKING CHANGE: Introduces a change to the
ExtensionDegreepublic API.