fix: malleable monero headers #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
SWvheerden
added a commit
to tari-project/tari
that referenced
this pull request
Aug 8, 2023
Description --- Forces the nonce of all Monero blocks to be 0. Motivation and Context --- The Nonce field in the header is used when calculating the hash of the block. When merge mining monero blocks, the nonce used by the monero mining sits in pow->monero_header->nonce. It does not use the tari block header nonce. But this allows any node to change the nonce in the header and not break the mined pow, but change the hash of monero header. This will cause the network to fork of valid mined monero blocks. How Has This Been Tested? --- unit tests RFC update: tari-project/rfcs#104
CjS77
approved these changes
Sep 14, 2023
CjS77
pushed a commit
that referenced
this pull request
Dec 19, 2023
Description --- Adds a rule to RandomX headers to stop RandomX headers from being malleable. Changes Sha -> Sha3x Monero -> RandomX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a rule to RandomX headers to stop RandomX headers from being malleable.
Changes Sha -> Sha3x
Monero -> RandomX