fix: add checking for Blake256 parameters #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
force-pushed
the
dk-blake2-with-params-result
branch
2 times, most recently
from
a6ff213
to
fa12759
Compare
hansieodendaal
previously approved these changes
Jul 11, 2022
src/hash/error.rs
Outdated
| pub enum HashError { | ||
| /// Length of input data exceeded a limit | ||
| #[error("wrong length")] | ||
| WorngLength, |
There was a problem hiding this comment.
Suggested change
| WorngLength, | |
| WrongLength, |
src/hash/blake2.rs
Outdated
| )) | ||
| pub fn with_params(key: &[u8], salt: &[u8], persona: &[u8]) -> Result<Self, HashError> { | ||
| if salt.len() > 16 || persona.len() > 16 { | ||
| Err(HashError::WorngLength) |
There was a problem hiding this comment.
Suggested change
| Err(HashError::WorngLength) | |
| Err(HashError::WrongLength) |
therustmonk
force-pushed
the
dk-blake2-with-params-result
branch
from
fa12759
to
0ff24df
Compare
|
I propose we add another function to make full use of the flexibility provided by pub fn with_params_var_size(key: &[u8], salt: &[u8], persona: &[u8], output_size: usize) -> Result<Self, HashError> |
| } | ||
|
|
||
| /// Constructs a `Blake256` hashing context with an explicitly specified output size. | ||
| pub fn with_params_var_size( |
There was a problem hiding this comment.
I think we need a unit test for this and for pub fn with_params testing all the edge cases.
stringhandler
approved these changes
Jul 26, 2022
aviator-app bot
pushed a commit
to tari-project/tari
that referenced
this pull request
Aug 8, 2022
Description --- The update for the upcoming `tari-crypto` updates: - tari-project/tari-crypto#117 - tari-project/tari-crypto#112 Motivation and Context --- How Has This Been Tested? ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds checking for
Blake256parameters: salt and persona should be less or equal 16 bytes length.Motivation: the fixes for #110.