Add signing methods for pre-determined nonces #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
force-pushed
the
mb-add-sign-with-nonce
branch
from
fe097d5
to
00696ad
Compare
CjS77
previously approved these changes
Nov 23, 2020
| /// key and a specified private nonce. DO NOT reuse nonces. This method is provide for cases where a | ||
| /// public nonce has been used | ||
| /// in the message. | ||
| #[wasm_bindgen] |
There was a problem hiding this comment.
I think you meant pre-hashed message, but can you explain what "hashed using the given private key" means? You usually hash with a hashing algorithm.
There was a problem hiding this comment.
Yeah needs a comma or something. PHRASING.
Generate a Schnorr signature of a challenge (that has already been hashed) using the given private
In some cases, the public nonce used in the signature is committed and used in the challenge. These extra methods allow signing with a private nonce to accommodate that. There is also support for signing a pre-hashed byte array instead of a string message
stringhandler
force-pushed
the
mb-add-sign-with-nonce
branch
from
00696ad
to
6ed84e2
Compare
CjS77
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the public nonce used in the signature is committed and
used in the challenge. These extra methods allow signing with a private
nonce to accommodate that. There is also support for signing a pre-hashed
byte array instead of a string message