fix: remove extra compress call during pubkey::deserialize #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
reviewed
Sep 5, 2021
src/ristretto/ristretto_keys.rs
Outdated
| @@ -219,6 +219,13 @@ impl RistrettoPublicKey { | |||
| compressed: pk.compress(), | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn new_from_compressed(compressed: CompressedRistretto) -> Option<RistrettoPublicKey> { | |||
There was a problem hiding this comment.
Feel like this should return a Result since our contract is that we always store a valid compressed/decompressed pair.
There was a problem hiding this comment.
There isn't an Error struct yet in the crate for this kind of error, and the method is only called privately from Deserialize which already exposes a ByteArrayError, so I restricted it further to super to reflect that it is private only and kept it as the Option that dalek exposes.
sdbondi
reviewed
Sep 5, 2021
There was a problem hiding this comment.
Nice, this should improve performance - just one extra clone.
Just as a sanity check I ran the dalek benches, LGTM
RistrettoPoint decompression
time: [5.7858 us 5.8601 us 5.9463 us]
change: [-3.5477% -2.4195% -1.2709%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
RistrettoPoint compression
time: [4.0617 us 4.0944 us 4.1341 us]
change: [-52.136% -48.548% -45.005%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
9 (9.00%) high mild
1 (1.00%) high severe
stringhandler
force-pushed
the
mb-new-pk
branch
from
d496cdb
to
3862d28
Compare
stringhandler
added a commit
that referenced
this pull request
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During deserialization, the compress and decompress method is called, when only one of them needs to be.
This should halve the time during
from_bytes()