Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip chore: move domain hash names to separate crate #774

Closed
wants to merge 2 commits into from

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Nov 20, 2023

Description

Refactor out the common hash domain names between tari and tari-dan repos.

Motivation and Context

Constants should always be defined at one place.

Requires PR tari-project/tari#6076

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Nov 20, 2023

Test Results (CI)

195 tests  ±0   195 ✅ ±0   1h 28m 8s ⏱️ - 16m 11s
 52 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 9fc43ca. ± Comparison against base commit 60b067c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the removed hash domains match those of the imported crate.

@Cifko Cifko marked this pull request as draft January 16, 2024 18:07
@Cifko Cifko changed the title chore: move domain hash names to separate crate wip chore: move domain hash names to separate crate Jan 17, 2024
@Cifko Cifko closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants