-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tx-builder): allow building unsigned transactions #939
Merged
sdbondi
merged 6 commits into
tari-project:development
from
sdbondi:transaction-unsigned-transaction
Mar 12, 2024
Merged
refactor(tx-builder): allow building unsigned transactions #939
sdbondi
merged 6 commits into
tari-project:development
from
sdbondi:transaction-unsigned-transaction
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
transaction-unsigned-transaction
branch
from
February 19, 2024 14:55
614d507
to
39d26e7
Compare
Test Results (CI)498 tests +1 497 ✅ +3 2h 50m 10s ⏱️ + 1m 18s For more details on these failures, see this check. Results for commit a7d0329. ± Comparison against base commit f449801. ♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
transaction-unsigned-transaction
branch
4 times, most recently
from
February 20, 2024 10:02
71644d8
to
5d6efd0
Compare
sdbondi
force-pushed
the
transaction-unsigned-transaction
branch
from
February 20, 2024 10:06
5d6efd0
to
16da161
Compare
stringhandler
previously approved these changes
Feb 27, 2024
* development: feat(walletd/js/client): use abstract transport to allow for WebRTC transport (tari-project#943) fix(engine): prevent creation of mismatched resource type bucket (tari-project#940) chore: update to latest feature-dan2 (tari-project#937) feat!: optional versions in transaction inputs (tari-project#922) feat: add tari-generate (tari-project#941)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Mar 12, 2024
* development: fix(wallet): preserve parent when recording substate addresses (tari-project#955) refactor(engine)!: store NFT data as CBOR value (tari-project#957) fix(vn/webui): fix template table (tari-project#962) fix(walletd): fix query for NonFungible (tari-project#950) refactor(tx-builder): allow building unsigned transactions (tari-project#939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor(tx-builder): allow building unsigned transactions
Motivation and Context
We have a few interfaces for submitting transactions, each of these has several fields that are duplicated across types. Some have missing fields simply because a particular transaction feature is unused. This PR adds the UnsignedTransaction type that is built using the TransactionBuilder and given to a wallet for signing.
We could also build a typescript version of the transaction builder to make building well-formed transactions easy.
This PR also adds an optional field to accept the UnsignedTransaction to the wallet daemon. If not specified, the separate fields are used as before to preserve backward compatibility. The idea would be to remove these later in another PR.
How Has This Been Tested?
Updated some cucumber steps to use this
What process can a PR reviewer use to test or verify this change?
Breaking Changes