feat: add launchpad downloads #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
reviewed
Jan 24, 2024
_data/launchpad_downloads.yml
Outdated
| @@ -22,7 +22,7 @@ | |||
| archOptions: | |||
| [{ value: arm64, label: arm64 }, { value: x86_64, label: x86_64 }] | |||
| networkOptions: | |||
| [{ value: nextnet, label: Nextnet }, { value: stagenet, label: Stagenet }] | |||
| [{ value: nextnet, label: Nextnet }, { value: testnet, label: Testnet }] | |||
There was a problem hiding this comment.
There is no "testnet"
It's either stagenet or nextnet
There was a problem hiding this comment.
I updated it to only use nextnet
CjS77
reviewed
Jan 25, 2024
_includes/head.html
Outdated
| @@ -99,7 +99,8 @@ | |||
| dataKey: "tari-project/wallet-ios", | |||
| elementPrefix: "wallet", | |||
| } | |||
| ] | |||
| ], | |||
| networks: ["nextnet", "testnet"], | |||
There was a problem hiding this comment.
Sorry, I missed that one - removed it
CjS77
approved these changes
Jan 25, 2024
ghpbot-tari-project
pushed a commit
that referenced
this pull request
Jan 26, 2024
* feat: add launchpad download section Adds section for Launchpad downloads. TODO: Js and YML needs to be updated to point to the launchpad binaries, with correct filters (when they exist) * feat: add launchpad downloads (#200) * feat: add launchpad downloads * feat: downloads updates * feat: replace testnet with stagenet * fix: remove testnet * Apply suggestions from code review Fixing links * feat: download button error handling (#201) --------- Co-authored-by: Erika <87762061+NovaT82@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new images / videos for the launchpad downloads section.
Cleaned up the downloads layout on the homepage.
Put in a ternary statement to check on which page the
downloads.jsfile is being called and depending on the location a different url will be called for the downloads fetch.Awaiting the final url for the launchpad section - this will need to be updated for the Launchpad downloads section to work.