feat: render logs #223
Merged
feat: render logs #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
force-pushed
the
render-values
branch
from
f731d82
to
d7047f9
Compare
CjS77
reviewed
Aug 3, 2023
libs/protocol/src/container.rs
Outdated
| #[derive(Debug, Clone, AsRefStr, Serialize_repr, Deserialize_repr)] | ||
| #[repr(u16)] | ||
| pub enum LogLevel { | ||
| Trace = 0, |
There was a problem hiding this comment.
did you mean to use a binary bitmap here?
There was a problem hiding this comment.
I only wanted to use numbers instead of strings, and using separate digits had no particular purpose. However, I like the idea of using a bitmap here. I'll update it.
There was a problem hiding this comment.
I meant to say bit mask, but I think you got it :)
therustmonk
force-pushed
the
render-values
branch
from
d7047f9
to
008bccd
Compare
CjS77
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces log rendering capabilities to the CLI interface.
Motivation and Context
Mirroring a feature already present in the Web UI prototype.
How Has This Been Tested?
Manually, CI