feat: remove spin lock #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed spin lock in update loop. Events are being processed correctly and this is not required. Added a bunch of trace logs to monitor the continued operation.
brianp
reviewed
Feb 9, 2024
brianp
approved these changes
Feb 9, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tari-launchpad/libs/sdm/src/task.rs::update. Events are being processed correctly and this is not required.Note: The spinlock was pointed out by @stringhandler.
Motivation and Context
The spin lock unnecessarily kept the system busy during shutdown.
How Has This Been Tested?
System-level testing: