fix: block sync validation #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a |
sdbondi
previously approved these changes
Sep 8, 2021
stringhandler
added
mq-approved
and removed
P-do_not_merge
Consolidate validation functions Add validation tests
SWvheerden
dismissed stale reviews from stringhandler and sdbondi
via
071cb97
SWvheerden
force-pushed
the
sw_fix_validation
branch
from
166798f
to
071cb97
Compare
sdbondi
approved these changes
Sep 8, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description --- This fixes the block sync block body validation to validate the correct items This consolidates all the syncing helper functions This adds in unit tests for the validators Motivation and Context --- Block sync needs to validate all the required steps. This also consolidates all the possible validation functions to remove duplicated pieces of code between the validators so we use a single piece to test a specific consensus item. How Has This Been Tested? --- Synced a node up to the tip height 22014. Added new unit tests. Ran all integration and unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the block sync block body validation to validate the correct items
This consolidates all the syncing helper functions
This adds in unit tests for the validators
Motivation and Context
Block sync needs to validate all the required steps. This also consolidates all the possible validation functions to remove duplicated pieces of code between the validators so we use a single piece to test a specific consensus item.
How Has This Been Tested?
Synced a node up to the tip height 22014.
Added new unit tests.
Ran all integration and unit tests.