feat: add logging of Monero PoW data to debug merge mining #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An intermittent error is being observed where Xmrig submits what it considers a valid PoW solution but the Base Node validation rejects the block with a low (1, 2, 3) difficulty. Adding two sets of logs to provide more detail on the data used to perform the RandomX hash when verifying a submitting merge mined block. Added a log to the Merge Mining Proxy to show the full Monero PoW data received from Xmrig and added a log in the Base Node to show the RandomX hash that it produces. These logs will help us confirm where the issue is in this disconnect between Xmrig’s calculation and our validation.
stringhandler
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An intermittent error is being observed where Xmrig submits what it considers a valid PoW solution but the Base Node validation rejects the block with a low (1, 2, 3) difficulty.
Adding two sets of logs to provide more detail on the data used to perform the RandomX hash when verifying a submitting merge mined block. Added a log to the Merge Mining Proxy to show the full Monero PoW data received from Xmrig and added a log in the Base Node to show the RandomX hash that it produces.
Motivation and Context
These logs will help us confirm where the issue is in this disconnect between Xmrig’s calculation and our validation.
How Has This Been Tested?
Manually