fix: dedup sql error when deleting many entries #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ERROR Error when trimming message dedup cache: ResultError(DatabaseError(__Unknown, "too many SQL variables"))
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description --- Fixes ERROR Error when trimming message dedup cache: ResultError(DatabaseError(__Unknown, "too many SQL variables")) Motivation and Context --- Bug fix when trimming many rows. Cleanup performance will also be better How Has This Been Tested? --- Existing test pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ERROR Error when trimming message dedup cache:
ResultError(DatabaseError(__Unknown, "too many SQL variables"))
Motivation and Context
Bug fix when trimming many rows. Cleanup performance will also be better
How Has This Been Tested?
Existing test pass