fix: always grow database when asked to resize #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a resize is detected as needed, we no longer need to do threshold checking. Simply grow the database by the configured amount. Increase the number of MAX_RESIZES in a transaction to accomodate very large transactions (interestingly, needed during rewind-blockchain for > 1000 blocks, depending on configured resize growth). - Fix incorrect error log in lmdb helper functions. - Check for MAP_FULL in lmdb_replace
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description --- When a resize is detected as needed, we no longer need to do threshold checking. Simply grow the database by the configured amount. Increase the number of MAX_RESIZES in a transaction to accomodate very large transactions (interestingly, needed during rewind-blockchain for > 1000 blocks, depending on configured resize growth). - Fix incorrect error log in lmdb helper functions. - Check for MAP_FULL in lmdb_replace Motivation and Context --- Bug fixes How Has This Been Tested? --- using rewind-blockchain on base node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a resize is detected as needed, we no longer need to do threshold
checking. Simply grow the database by the configured amount.
Increase the number of MAX_RESIZES in a transaction to accomodate very
large transactions (interestingly, needed during rewind-blockchain for >
1000 blocks, depending on configured resize growth).
Motivation and Context
Bug fixes
How Has This Been Tested?
using rewind-blockchain on base node