fix: dead_code lint error when base_node_feature is not set #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine, I went the other way in #3353 adding the base_node feature to that function - is it that an issue? |
|
@delta1 Yeah I did that at first, but feels like the feature attrs are getting messier and messier. If you feel strongly one way we can close this. |
|
No I agree, I prefer this way 👍 |
stringhandler
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
new_sorted_uncheckedfunction to keep clippy happy when base_node feature is not activein tari_core.
Motivation and Context
Causing failed CI build (e.g. #3335 )
How Has This Been Tested?
CI must pass (FFI tests)