fix: reduce console wallet tui memory usage #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_reduce_tui_memory_usage
branch
2 times, most recently
from
f28e87e
to
2bbd04d
Compare
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Sep 28, 2021
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Sep 28, 2021
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Sep 28, 2021
hansieodendaal
force-pushed
the
ho_reduce_tui_memory_usage
branch
from
2bbd04d
to
db07817
Compare
| #[derive(Clone)] | ||
| pub struct CompletedTransactionInfo { | ||
| pub tx_id: TxId, | ||
| pub source_public_key: CommsPublicKey, |
There was a problem hiding this comment.
Can reduce memory usage even more by storing the text representation instead of the crypto primitive
Suggested change
| pub source_public_key: CommsPublicKey, | |
| pub source_public_key: String, |
| pub struct CompletedTransactionInfo { | ||
| pub tx_id: TxId, | ||
| pub source_public_key: CommsPublicKey, | ||
| pub destination_public_key: CommsPublicKey, |
stringhandler
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transactional information is copied to an internal buffer for the console wallet to use in its screen refresh tick cycle and updates to this information are event-driven. This PR reduces the memory overhead required to keep transactions in their various life cycle stages in the buffer memory.
Motivation and Context
Unnecessary memory was allocated to the internal buffer as the entire completed transaction body was kept while only the signature(s) and maturity is required. This is more significant for large wallets.
How Has This Been Tested?
System-level testing