feat!: expose reason for transaction cancellation for callback in wallet_ffi #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
changed the title
StriderDM
force-pushed
the
cancelled_callback_reason
branch
from
df2e4d2
to
239b22c
Compare
philipr-za
reviewed
Nov 22, 2021
StriderDM
force-pushed
the
cancelled_callback_reason
branch
from
239b22c
to
85d8b00
Compare
philipr-za
reviewed
Nov 23, 2021
Update cancellation callback and transaction protocols Update unit tests Update integration tests Update wallet header Clippy fixes Review comments Update documentation
StriderDM
force-pushed
the
cancelled_callback_reason
branch
from
85d8b00
to
8372bef
Compare
philipr-za
approved these changes
Nov 23, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 23, 2021
* development: fix: seed word parsing (tari-project#3607) feat: add ban peers metric (tari-project#3605) feat!: expose reason for transaction cancellation for callback in wallet_ffi (tari-project#3601) test: improve cucumber scenario robustness (tari-project#3599) feat: use CipherSeed wallet birthday for recovery start point (tari-project#3602) docs: ignore RFC code blocks (tari-project#3603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes reason for transaction cancellation to wallet_ffi via the transaction cancellation callback.
Additionally removes outdated docs and fixes Clippy errors.
Motivation and Context
How Has This Been Tested?
cargo test --all