feat: base_node switching for console_wallet when status is offline #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Dec 5, 2021
base_layer/wallet/src/base_node_service/mock_base_node_service.rs
Outdated
Show resolved
Hide resolved
StriderDM
force-pushed
the
switch_when_node_offline
branch
from
6475b57
to
52ff5d4
Compare
philipr-za
reviewed
Dec 6, 2021
StriderDM
force-pushed
the
switch_when_node_offline
branch
from
52ff5d4
to
2acf19c
Compare
philipr-za
reviewed
Dec 8, 2021
There was a problem hiding this comment.
Looking better now that it is driven by the event.
Something that is still missing from the original ticket spec is that the automatic switch should only happen is a custom base node is NOT set. If a custom base node is set then this should not happen.
Looking at it again I see now that the duplicated connectivity status was not just in the cached stated but all the way in the Base Node monitoring service which is not right.
StriderDM
force-pushed
the
switch_when_node_offline
branch
2 times, most recently
from
bb6e539
to
c9f9f04
Compare
philipr-za
previously approved these changes
Dec 9, 2021
|
Clippy says no |
This PR allows the console_wallet to periodically attempt to connect to another base_node in the list should it be found to be offline.
StriderDM
force-pushed
the
switch_when_node_offline
branch
from
46ea4a7
to
39e7f1c
Compare
philipr-za
approved these changes
Dec 22, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 3, 2022
* weatherwax: feat: add search by commitment to explorer (tari-project#3668) feat: tari launchpad (tari-project#3671) feat: base_node switching for console_wallet when status is offline (tari-project#3639) feat: improve wallet recovery and scanning handling of reorgs (tari-project#3655) feat: add GRPC call to search for utxo via commitment hex (tari-project#3666) feat: custom_base_node in config (tari-project#3651) fix: return correct index for include_pruned_utxos = false (tari-project#3663)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 7, 2022
* development: chore: remove moving lock.mdb (tari-project#3674) chore: merge weatherwax feat!: provide a compact form of TransactionInput (tari-project#3460) v0.22.1.1 v0.22.1 ci: add build step (tari-project#3678) fix: edge cases causing bans during header/block sync (tari-project#3661) fix: end stale outbound queue immediately on disconnect, retry outbound messages (tari-project#3664) feat: add search by commitment to explorer (tari-project#3668) feat: tari launchpad (tari-project#3671) feat: base_node switching for console_wallet when status is offline (tari-project#3639) feat: improve wallet recovery and scanning handling of reorgs (tari-project#3655) feat: add GRPC call to search for utxo via commitment hex (tari-project#3666) feat: custom_base_node in config (tari-project#3651) fix: return correct index for include_pruned_utxos = false (tari-project#3663)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 10, 2022
* development: feat: dibbler new genesis block with faucet utxos (tari-project#3688) ci: fix clippy warning on generated proto module (tari-project#3690) test: fix metadata signature cucumber (tari-project#3687) refactor!: clean up #testnet reset TODOs (tari-project#3682) feat(comms)!: add signature to peer identity to allow third party identity updates (tari-project#3629) chore: remove moving lock.mdb (tari-project#3674) chore: merge weatherwax v0.22.1.1 v0.22.1 ci: add build step (tari-project#3678) fix: edge cases causing bans during header/block sync (tari-project#3661) fix: end stale outbound queue immediately on disconnect, retry outbound messages (tari-project#3664) feat: add search by commitment to explorer (tari-project#3668) feat: tari launchpad (tari-project#3671) feat: base_node switching for console_wallet when status is offline (tari-project#3639) feat: improve wallet recovery and scanning handling of reorgs (tari-project#3655) feat: add GRPC call to search for utxo via commitment hex (tari-project#3666) feat: custom_base_node in config (tari-project#3651) fix: return correct index for include_pruned_utxos = false (tari-project#3663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the console_wallet to periodically attempt to connect to another base_node in the list should it be found to be offline.
Motivation and Context
Usability.
How Has This Been Tested?
cargo test --all
nvm use 12.22.6 && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken"
manually