feat: prevent ambiguous output features in transaction protocols #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed possible ambiguous use of output features when creating the SingleReceiverTransactionProtocol and TransactionSenderMessage.
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 1, 2022
* development: chore: check genesis block during startup (tari-project#3776) chore: fix lint again (tari-project#3780) fix(core): fetch_header_containing_*_mmr functions now take a 0-based mmr position (tari-project#3749) refactor(test_faucet): include create_utxo to avoid unintentionally breaking faucet utxos (tari-project#3771) fix: text explorer show sha-3 correctly + minor fixes (tari-project#3779) feat: prevent ambiguous output features in transaction protocols (tari-project#3765)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevented possible ambiguous use of output features when creating the
SingleReceiverTransactionProtocolandTransactionSenderMessage.Note:
SingleRoundSenderDataalready containsOutputFeaturesMotivation and Context
Ambiguity when constructing transaction protocols should not be possible.
How Has This Been Tested?
npm test -- --tags "@critical")