feat(ffi)!: add features, metadata_signature and sender_offset_public_key to import_utxo #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-import-utxo-sopk
branch
from
d8de2e6
to
595e50e
Compare
sdbondi
changed the title
sdbondi
force-pushed
the
wallet-import-utxo-sopk
branch
from
595e50e
to
bea1748
Compare
SWvheerden
previously approved these changes
Jan 28, 2022
|
@SWvheerden ok so I think we may as well do that, and if the wallet passes null in we use defaults - wasnt sure if adding new types to ffi is a pain or not - but looks like it's not a problem in unsafe land :) |
…_public_key to import_utxo
sdbondi
force-pushed
the
wallet-import-utxo-sopk
branch
from
bea1748
to
c6bd6f2
Compare
sdbondi
force-pushed
the
wallet-import-utxo-sopk
branch
from
1210a7b
to
c6bd6f2
Compare
stringhandler
approved these changes
Jan 28, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 31, 2022
* development: (29 commits) feat(base-node): add base node prometheus metrics (tari-project#3773) fix(ffi): mut pointers should be const (tari-project#3775) chore: update launchpad for dibbler (tari-project#3769) v0.27.3 fix(ffi): missing param in header.h (tari-project#3774) v0.27.2 v0.27.2 fix(ffi): fix bad access (tari-project#3772) chore(collectibles): fix eslint v0.27.1 fix(ffi): fix null pointer assignment in import_utxo (tari-project#3770) fix(validators): check input metadata matches spending output (tari-project#3761) v0.27.0 feat(ffi)!: Add commitment_signature_create and destroy (tari-project#3768) feat(ffi)!: add features, metadata_signature and sender_offset_public_key to import_utxo (tari-project#3767) feat(explorer): better view on mempool (tari-project#3763) feat: update the available balance in console wallet (tari-project#3760) chore: reclassify very long log message (tari-project#3752) fix: fix cucumber test for standard recovery (tari-project#3757) style: format with prettier (same settings as in integration tests) (tari-project#3756) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wallet_import_utxo(features, metadata_signature and sender_offset_public_key)Motivation and Context
Allows faucet utxos to be imported to the wallet db correctly
How Has This Been Tested?