feat(wallet_ffi)!: add base node connectivity callback to wallet ffi #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new callback to the FFI interface that fires when there is a change in the wallet’s connectivity to the set base node. This information was already available from the Wallet Connectivity Service via a watch channel and this PR just hooks up this watch channel to the Wallet FFI callback handler. The unit test for the callback handler is updated to test the addition. feat: add specific LibWallet error code for “Fee is greater than amount” Surfacing a specific error code for the “Fee is greater than amount” Transaction Build error.
|
That was quite a random looking segfault in the FFI integration tests, just want to see if it happens again. |
I forgot to update the FFI cucumber tests, will fix soon |
delta1
approved these changes
Feb 5, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 8, 2022
* development: refactor: reduce log level of some messages (tari-project#3804) ci: move Apple IDs into envs (tari-project#3797) feat: read asset definitions from base layer (tari-project#3802) fix: bump flood ban messages config (tari-project#3799) docs: readme fixes (tari-project#3800) feat(wallet_ffi)!: add base node connectivity callback to wallet ffi (tari-project#3796) fix: minor fixes on collectibles (tari-project#3795) refactor: outbound message pipeline, threads and mempool improvements (tari-project#3792) feat(collectibles): add delete committee member button (tari-project#3786) fix(comms): minor edge-case fix to handle inbound connection while dialing (tari-project#3785) fix(core)!: fix potential panic for sidechain merkle root with incorrect length (tari-project#3788) fix(core): reduce one block behind waiting period (tari-project#3798) feat: add specific LibWallet error code for “Fee is greater than amount” (tari-project#3793) fix: coinbase output recovery bug (tari-project#3789) feat(base-node): add number of active sync peers metric (tari-project#3784) chore: script to keep .gitkeep file (tari-project#3787) feat: re-use scanned range proofs (tari-project#3764) feat: ability to compile on stable rust (tari-project#3759) feat: add logging and config to collectibles (tari-project#3781) chore: remove debug info from get-mempool-state (tari-project#3782)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new callback to the FFI interface that fires when there is a change in the wallet’s connectivity to the set base node.
This information was already available from the Wallet Connectivity Service via a watch channel and this PR just hooks up this watch channel to the Wallet FFI callback handler.
How Has This Been Tested?
The unit test for the callback handler is updated to test the addition.