feat: add logging of cancelled outputs when transaction is rejected #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR just adds some logging of which outputs were specifically cancelled when a transaction is reject by the base node. In addition when an output is marked as Unspent we also clear the Mined In Block field which will result in that output being revalidated the next time a validation is done.
delta1
reviewed
Feb 22, 2022
base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
Outdated
Show resolved
Hide resolved
delta1
approved these changes
Feb 22, 2022
stringhandler
pushed a commit
that referenced
this pull request
Sep 16, 2022
…lled (#4686) Description --- - Sets output `mined_height` in addition to `mined_in_block` to NULL when cancelling pending transactions - renames `set_output_to_unmined` to `set_output_to_unmined_and_invalid` Motivation and Context --- This can cause #4670 and was introduced in #3863 `set_output_to_unmined` also marks the output as invalid which is unexpected given the name. How Has This Been Tested? --- Additional basic test for `set_output_to_unmined`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just adds some logging of which outputs were specifically cancelled when a transaction is reject by the base node. In addition when an output is marked as Unspent we also clear the Mined In Block field which will result in that output being revalidated the next time a validation is done.