Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aligned tables left #3899

Merged
merged 5 commits into from Mar 14, 2022
Merged

Conversation

NovaT82
Copy link
Contributor

@NovaT82 NovaT82 commented Mar 7, 2022

Description

Aligned tables to left on RFC docs

Motivation and Context

Smaller tables look better when not centered

How Has This Been Tested?

Tested locally

Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@delta1
Copy link
Contributor

delta1 commented Mar 8, 2022

bors r+

bors bot added a commit that referenced this pull request Mar 8, 2022
3899: fix: aligned tables left r=delta1 a=NovaT82

Description
---
Aligned tables to left on RFC docs

Motivation and Context
---
Smaller tables look better when not centered

How Has This Been Tested?
---
Tested locally


3902: fix(core): correctly filter pruned sync peers for block sync r=delta1 a=sdbondi

Description
---
Corrects filter predicate for full block sync peers

Motivation and Context
---
Rpc error: `Service returned an error: BadRequest: Requested full block body at height 6804, however this node has an effective pruned height of 15941` caused by peer incorrectly selecting pruned nodes. 

How Has This Been Tested?
---
Manually


Co-authored-by: NovaT82 <nova@tari.com>
Co-authored-by: Byron Hambly <bizzle@tari.com>
Co-authored-by: Stanimal <sdbondi@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 8, 2022

This PR was included in a batch that successfully built, but then failed to merge into development. It will not be retried.

Additional information:

{"message":"Required status check \"check-title\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@aviator-app aviator-app bot merged commit 1279773 into tari-project:development Mar 14, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Mar 15, 2022
* development: (118 commits)
  chore: clean up providing seed words from LibWallet (tari-project#3906)
  chore: move tari_script into its own crate (tari-project#3909)
  fix(consensus): check blockchain version within valid range (tari-project#3916)
  ci: fix missing npm deps and add javascript ci (tari-project#3910)
  refactor: use clap as a commands parser (tari-project#3867)
  chore: use git tagged tari_utilities and tari-crypto deps (tari-project#3913)
  fix: aligned tables left (tari-project#3899)
  ci: fix vue build
  v0.29.0
  feat!: add recovery byte to output features (tari-project#3727)
  add ffi ci check (tari-project#3915)
  fix(block-sync): use avg latency to determine slow sync peer for block sync (tari-project#3912)
  fix: fix merge mining proxy pool mining (tari-project#3814)
  revert: remove use of blocking tasks for DHT db (reverts tari-project#3887) (tari-project#3901)
  chore: add license info missing from some crates (tari-project#3892)
  fix(core): correctly filter pruned sync peers for block sync (tari-project#3902)
  ci: revert bors squash merge (tari-project#3900)
  fix: update metadata size calculation to use FixedSet.iter()
  docs(rfc): deep links structure convention - deep links is use (tari-project#3897)
  ci: use squash merge for bors (tari-project#3896)
  ...
sdbondi added a commit to Cifko/tari that referenced this pull request Mar 16, 2022
* development:
  chore: clean up providing seed words from LibWallet (tari-project#3906)
  chore: move tari_script into its own crate (tari-project#3909)
  fix(consensus): check blockchain version within valid range (tari-project#3916)
  ci: fix missing npm deps and add javascript ci (tari-project#3910)
  refactor: use clap as a commands parser (tari-project#3867)
  chore: use git tagged tari_utilities and tari-crypto deps (tari-project#3913)
  fix: aligned tables left (tari-project#3899)
  ci: fix vue build
  v0.29.0
  feat!: add recovery byte to output features (tari-project#3727)
  add ffi ci check (tari-project#3915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants