Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mmr check to reconstructed block and mempool validation for unique excess signature #3930

Merged
merged 1 commit into from
Mar 21, 2022
Merged

feat: add mmr check to reconstructed block and mempool validation for unique excess signature #3930

merged 1 commit into from
Mar 21, 2022

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Mar 18, 2022

Description

  • Adds a check to the reconstructed block to ensure MMR roots match, if not then requests the full block from source peer
  • Adds mempool validation to check submitted kernel excess signature does not already exist in the chain db

@delta1 delta1 requested a review from sdbondi March 18, 2022 11:35
sdbondi
sdbondi approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, think this handles the case well

base_layer/core/src/base_node/comms_interface/inbound_handlers.rs Show resolved Hide resolved
@aviator-app aviator-app bot merged commit b8f9db5 into tari-project:development Mar 21, 2022
@delta1 delta1 deleted the excess branch March 22, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delta1 @sdbondi