fix: fix ffi import external utxo from faucet #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base_layer/wallet_ffi/src/lib.rs
Outdated
| ptr::swap(error_out, &mut error as *mut c_int); | ||
| return 0; | ||
| } | ||
| let mut updated_features = if features.is_null() { |
There was a problem hiding this comment.
This is wrong. It should error
base_layer/wallet_ffi/src/lib.rs
Outdated
| // On the blockchain, 'V0' of the output features encode and decode without the recovery byte, whereas 'V1' onwards | ||
| // adds it in, however, for the wallet, the recovery byte must be consistent with the value commitment to be | ||
| // accepted in the wallet irrespective if it is 'V0' or 'V1' | ||
| let recovery_byte = |
There was a problem hiding this comment.
This should not be calculated. It should be imported as provided
base_layer/wallet_ffi/src/lib.rs
Outdated
| return 0; | ||
| }, | ||
| }; | ||
| updated_features.set_recovery_byte(recovery_byte); |
There was a problem hiding this comment.
If you change the data here, the hash will change
- Fixed importing external UTXOs via the FFI; changed the philosophy about having inconsistent recovery byte data in the wallet database. - Renamed import UTXO methods to be more descriptive - Added a unit test to test importing external UTXOs via the FFI
hansieodendaal
force-pushed
the
ho_fix_ffi_import_utxo
branch
from
2338cbd
to
c1ffe63
Compare
|
Changed the philosophy about having inconsistent recovery byte data in the wallet database |
stringhandler
changed the title
stringhandler
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: The FFI import UTXO method was renamed; this is a breaking change on the FFI interface.
Motivation and Context
See above
How Has This Been Tested?
Added a new unit test that test the import UTXO interface