Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check file perms on identity files #3958

Merged
merged 3 commits into from Apr 5, 2022
Merged

feat: check file perms on identity files #3958

merged 3 commits into from Apr 5, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Mar 25, 2022 •
edited

Description

  • adds check for o+rw file permissions for node and tor identity files on unix family systems
  • adds an error type for common identity module
  • improves hint output on failure
  • clean up duplicate tor help message in code
  • adds "watch status" to rustyline history
  • remove get LAN ip functionality, since it is not useful, remove get_if_addrs dependency

Motivation and Context

Checking for and rejecting open file permissions on identity files is good practice (a la ~/.ssh)

How Has This Been Tested?

Manually, setting incorrect permissions on node identity and tor identity
Shutting down tor and checking that the base node and wallet emit the correct message

delta1
delta1 previously approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, untested

stringhandler
stringhandler previously approved these changes Apr 4, 2022
View reviewed changes
@sdbondi sdbondi dismissed stale reviews from stringhandler and delta1 via 0b1f8c5 April 4, 2022 13:05
@aviator-app aviator-app bot added the mq-failed label Apr 4, 2022
@aviator-app aviator-app bot removed the mq-failed label Apr 5, 2022
@aviator-app aviator-app bot merged commit 7f381d3 into tari-project:development Apr 5, 2022
@sdbondi sdbondi deleted the apps-check-identity-permissions branch April 5, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@delta1 delta1 delta1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdbondi @delta1 @stringhandler