Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet_ffi): new ffi method to create output features (fixed flag size for dibbler) #4118

Merged

Conversation

mrnaveira
Copy link
Contributor

Description

  • Created a new FFI method to create an output features object, by passing the byte values as parameters.
  • I decided to not expose the DAN layer features, as they are most likely going to change and also would require exposing more struct definitions.
  • Updated the C header with the definition of the new method

Motivation and Context

Currently the mobile apps cannot properly import faucet UTXOs, as they are passing null values for output features and covenants to the wallet_import_external_utxo_as_non_rewindable method, which is not allowed. So the mobile apps needs new FFI methods to create both output features and covenants. This pull request deals with output features only.

This PR is an adaptation due to the output flags size, as the original PR was done over development which has consensus breaking changes (flag size was increased from 1 byte to 2 bytes).

How Has This Been Tested?

Created two new unit tests for the new FFI method

@stringhandler stringhandler merged commit cf3a1e6 into tari-project:testnet-dibbler May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants