Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use tari_crypto's updated "extended pedersen commitment factory" #4206

Merged
merged 3 commits into from
Jun 16, 2022
Merged

feat: use tari_crypto's updated "extended pedersen commitment factory" #4206

merged 3 commits into from
Jun 16, 2022

Conversation

hansieodendaal
Copy link
Contributor

Description

Update tari_crypto

  • Updated tari_crypto to the latest version
  • Switched to 'ExtendedPedersenCommitmentFactory' from 'PedersenCommitmentFactory'

Notes:

  • No functional changes, no commitment changes, no Bulletproof range proof changes.
  • Temporary use of the git commit instead of a tag for tari-crypto and in the cargo.toml files

Motivation and Context

Preparation for tari_bulletproofs_plus implementation.

How Has This Been Tested?

  • Existing unit tests pass
  • Existing integration tests pass

@hansieodendaal
Update tari_crypto
05722ce 
- Updated tari_crypto to the latest version
- Switch to 'ExtendedPedersenCommitmentFactory' from 'PedersenCommitmentFactory'

Note: No functional changes, no commitment changes, no Bulletproofs changes.
@hansieodendaal
update CryptoFactories
5bbfe76
@hansieodendaal hansieodendaal changed the title feat: use updated tari_crypto's extended pedersen commitment factory feat: use tari_crypto's updated "extended pedersen commitment factory" Jun 16, 2022
sdbondi
sdbondi approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal to use commit refs but we can fix this later

@aviator-app aviator-app bot merged commit 50ce20a into tari-project:development Jun 16, 2022
@hansieodendaal hansieodendaal deleted the ho_update_tari_crypto branch June 17, 2022 04:03
sdbondi added a commit to sdbondi/tari that referenced this pull request Jun 20, 2022
@sdbondi
Merge branch 'development' into wallet-contract-def-init-keymanager
0a7df24 
* development:
  feat(wallet): new cli commands to initialise proposals and amendments (tari-project#4205)
  feat: add an encrypted value to the TransactionOutput (tari-project#4148)
  feat: use tari_crypto's updated "extended pedersen commitment factory" (tari-project#4206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

@stringhandler stringhandler Awaiting requested review from stringhandler

@therustmonk therustmonk Awaiting requested review from therustmonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansieodendaal @sdbondi