fix(wallet): implement check_for_updates in wallet grpc
#4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-update-notify-grpc
branch
from
c67a8be
to
20fdb03
Compare
stringhandler
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check_for_updateswallet GRPC callnew_update_notifiertoupdate_notifierlatest_updatefunction toSoftwareUpdateHandleMotivation and Context
check_for_updateswallet grpc method was not implemented and currently panics.new_update_notifierwas badly named (by me) as it looks like it's creating a new update notifier - the word new is redundant.How Has This Been Tested?
Not currently tested, cucumber tests for wallet software update need to be worked on