Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base-node): fix messy output in base node console #4509

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 22, 2022

Description

Fixes messy base node console output

Motivation and Context

Base node error output would start in the middle of the console instead of at the beginning of a new line.
The cli loop can run on the main thread instead of in a task.

09:24 v0.35.0, esmeralda, State: Listening, Tip: 610 (Mon, 22 Aug 2022 05:17:47 +0000), Mempool: 0tx (0g, +/- 0blks), Connections: 0, Banned: 0, Messages (last 60s): 0, Rpc: 0/100
09:24 WARN  Connectivity is OFFLINE (0/1 connections)
09:24 WARN  Connectivity is OFFLINE. Waiting for connections...
09:24 v0.35.0, esmeralda, State: Listening, Tip: 610 (Mon, 22 Aug 2022 05:17:47 +0000), Mempool: 0tx (0g, +/- 0blks), Connections: 7, Banned: 0, Messages (last 60s): 10, Rpc: 0/100

How Has This Been Tested?

Manually

@sdbondi sdbondi force-pushed the base-node-fix-terminal-output branch from 6bf9fab to 001dfdd Compare August 22, 2022 05:27
@sdbondi sdbondi force-pushed the base-node-fix-terminal-output branch from 001dfdd to d72bd16 Compare August 22, 2022 05:31
@stringhandler stringhandler merged commit c2dfa23 into tari-project:development Aug 24, 2022
@sdbondi sdbondi deleted the base-node-fix-terminal-output branch August 24, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants