feat: console and FFI should have setting to not choose outputs that reveal the address #4403 #4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubarev
changed the title
…ontrols whether outputs received via a simple one-sided transaction are automatically selected by `select_utxos` when spending added `source` field to `outputs` table Signed-off-by: Andrei Gubarev <agubarev@users.noreply.github.com>
agubarev
force-pushed
the
issue-4403-ignore-onesided-outputs
branch
from
1d37cf7
to
c827735
Compare
agubarev
changed the title
agubarev
changed the title
agubarev
changed the title
sdbondi
reviewed
Aug 30, 2022
| @@ -200,13 +202,22 @@ impl OutputSql { | |||
| .filter(outputs::status.eq(OutputStatus::Unspent as i32)) | |||
| .order_by(outputs::spending_priority.desc()); | |||
|
|
|||
| eprintln!( | |||
base_layer/wallet/src/output_manager_service/storage/output_source.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: SW van Heerden <swvheerden@gmail.com>
…urce.rs Co-authored-by: Stan Bondi <sdbondi@users.noreply.github.com>
sdbondi
reviewed
Aug 31, 2022
| @@ -151,6 +152,7 @@ where | |||
| &self.rewind_data, | |||
| None, | |||
| Some(proof), | |||
| OutputSource::Recovered, | |||
There was a problem hiding this comment.
Even when recovered, the output should be marked according to its script (one-sided, stealth, standard, etc.)
sdbondi
previously approved these changes
Aug 31, 2022
stringhandler
previously approved these changes
Aug 31, 2022
Co-authored-by: stringhandler <stringhandler@gmail.com>
jorgeantonio21
pushed a commit
to jorgeantonio21/tari
that referenced
this pull request
Aug 31, 2022
…reveal the address tari-project#4403 (tari-project#4516) Description --- tari-project#4403 Wallet (console and FFI) should have setting to not choose outputs that reveal the address tari-project#4403 Motivation and Context --- Problem Wallets currently will choose the best outputs as inputs when spending, however since a lurking base node can generate a transaction graph of inputs to outputs with relative ease, a wallet may reveal its transaction history by including a (non-stealth address) one-sided payment. For example, an attacker wishing to know the transaction graph of a public key PK_Alice can send a one-sided payment to PK_Alice using the Tariscript Push(PK_Alice). At some point, Alice's wallet spends this transaction without realizing it. Possible solution Could change the wallet to have a config setting, to not include one-sided payments by default when spending How Has This Been Tested? ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4403
Wallet (console and FFI) should have setting to not choose outputs that reveal the address #4403
Motivation and Context
Problem
Wallets currently will choose the best outputs as inputs when spending, however since a lurking base node can generate a transaction graph of inputs to outputs with relative ease, a wallet may reveal its transaction history by including a (non-stealth address) one-sided payment.
For example, an attacker wishing to know the transaction graph of a public key PK_Alice can send a one-sided payment to PK_Alice using the Tariscript Push(PK_Alice). At some point, Alice's wallet spends this transaction without realizing it.
Possible solution
Could change the wallet to have a config setting, to not include one-sided payments by default when spending
How Has This Been Tested?