fix(comms/dht): fixes invalid peer ban on invalid encrypted msg signature #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Aug 24, 2022
sdbondi
deleted the
comms-dht-fix-invalid-ban-on-encrypted-sig-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Ref #4339
Previously, a sender may send a message with an invalid encrypted signature that cannot be validated and rejected by intermediate nodes. On receipt by the sender, an invalid signature is encountered and previously this would result in sending peer being banned. This PR changes this to only discard the message. The sender is only banned if unencrypted header data is malformed/invalid.
How Has This Been Tested?
New unit tests + existing tests + manually (no breaking changes)