feat!: add domain consensus hashing to all previous uses of default consensus hashing #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_consensus_default
branch
from
47d2a19
to
a1e0174
Compare
| @@ -364,18 +368,67 @@ pub(crate) mod hash_serializer { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) mod fixed_hash_serializer { | |||
There was a problem hiding this comment.
Strange place for this. Shouldn't this live with FixedHash ?
There was a problem hiding this comment.
This is in the same place as pub(crate) mod hash_serializer
When trying to move:
Module tari_core::blocks::block_header::fixed_hash_serializer uses module tari_core::blocks::block_header which will be inaccessible after move
- Added domain hashing to all previous uses of default consensus hashing. - Changed `output_mr`, `witness_mr `kernel_mr` and `input_mr` types in `pub struct BlockHeader` to be `FixedHash` instead of variable length `BlockHash`. - Fixed unit tests. - Fixed cucumber tests.
hansieodendaal
force-pushed
the
ho_consensus_default
branch
from
a1e0174
to
ea53fac
Compare
hansieodendaal
changed the title
stringhandler
approved these changes
Aug 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
output_mr,witness_mr,kernel_mrandinput_mrtypes inpub struct BlockHeaderto beFixedHashinstead of variable lengthBlockHash.Motivation and Context
As per issue #4396.
How Has This Been Tested?