Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console-wallet): adds basic grpc authentication #4532

Merged
merged 6 commits into from Aug 25, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 24, 2022

Description

  • adds basic password auth interceptor to wallet grpc.
  • disables grpc by default
  • adds hash-grpc-password command that produces a salted hashed password that clients can use for authentication
  • adds cli args to explicitly enable grpc
  • adds wallet.grpc_authentication configuration
  • allow grpc client to use basic auth if configured
  • add --enable-grpc cli flag to wallet

Motivation and Context

Fixes #4478
Secure GRPC calls with basic auth.
User should explicitly enable grpc when it is needed.

Usage:

  • Set grpc_authentication = { username: "foo", password: "bar" }
  • Call tari_console_wallet hash-grpc-password and copy the hash
  • Use the username and hashed password in e.g. postman or any other grpc client

How Has This Been Tested?

Basic unit tests
Manually (POSTman and running a miner with GRPC auth enabled)

@sdbondi sdbondi force-pushed the wallet-grpc-auth branch 4 times, most recently from 3cffeff to 40e7f44 Compare August 24, 2022 15:41
@stringhandler stringhandler merged commit 2615c1b into tari-project:development Aug 25, 2022
@sdbondi sdbondi deleted the wallet-grpc-auth branch August 25, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock down the transfer method on wallet GRPC to have some kind of authentication.
3 participants