Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix block consensus decoding and add tests #4537

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 25, 2022

Description

  • fix consensus decoding for transaction output
  • add tests for all impls of consensus encoding

Motivation and Context

Transaction output consensus decoding was missing encrypted value.
Tests picked this up.

How Has This Been Tested?

New tests

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdbondi sdbondi changed the title fix(core): fix block consensus encoding and add tests fix(core): fix block consensus decoding and add tests Aug 25, 2022
@SWvheerden
Copy link
Collaborator

Fixes: #4535

@stringhandler stringhandler merged commit 0a9d5ef into tari-project:development Aug 25, 2022
@sdbondi sdbondi deleted the consensus-enoding-review-and-tests branch August 25, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants