fix: add Grpc authentication to merge mining proxy (see issue #4587) #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4587. |
jorgeantonio21
force-pushed
the
ja_proxy_auth_for_grpc_merge_mining
branch
from
ab2e33e
to
25a763b
Compare
…for_grpc_merge_mining
sdbondi
previously approved these changes
Sep 1, 2022
sdbondi
reviewed
Sep 1, 2022
…eantonio21/tari into ja_proxy_auth_for_grpc_merge_mining
sdbondi
reviewed
Sep 1, 2022
sdbondi
reviewed
Sep 1, 2022
sdbondi
reviewed
Sep 1, 2022
sdbondi
reviewed
Sep 1, 2022
sdbondi
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is desirable that the Merge mining proxy has a GRPC authenticated wallet client connection.
Motivation and Context
Contrary to the Mining wallet client connection, the merge mining proxy does not have GRPC authentication currently. This issue aims to add it to GRPC auth in the merge mining proxy.
Fixes #4587.
How Has This Been Tested?
Existing unit tests